Skip to content

nodebb-plugin-reactions not working @v1.0.2 with Harmony theme

Solved General
  • @dave1904 Ok. I’ll login again later and take a look at this. I still think it’s related to dependencies.

  • @dave1904 I’ve managed to resolve this issue - see below

    204f1bd9-ede2-4c07-a357-a09ccddb379b-image.png

    It seems that there is a conflicting plugin somewhere that causes reactions to not fire. Not sure which one it is, but below are the steps I took to resolve

    1. Issue ./nodebb reset -t - this essentially resets everything back to default - be warned, as it will strip literally all customisations also
    2. Reactivate only the essential plugins (typically those that come with the stock installation)
    3. Install and activate nodebb-plugin-emoji, nodebb-plugin-emoji-android and @nodebb/nodebb-plugin-reactions@latest
    4. Rebuild and restart

    Obviously, these steps are quite dramatic and would mean some downtime for your forum. You’d also need to put everything back the way it was in terms of CSS, Widgets, etc, so quite invasive. My suggestion would be to try a minimal approach on prod to see if we can get that to work without having to use the somewhat “sledgehammer” approach above.

  • phenomlabundefined phenomlab has marked this topic as solved on
  • Again, thank you very much for taking your time. Very happy that you could fix it. 🙂 I guess the minimal approach would be to deactivate plugins one after another, rebuild and restart and see if the reactions plugin works?

  • @dave1904 yes, that’s the route I would take.

  • @phenomlab

    I will try this later and keep you updated.

  • @dave1904 any update? More to the point, so you need any help?

  • @phenomlab

    At the moment I try it the other way around so avoid downtime on prod: Activating plugins on dev to see if reactions stops working. Will keep you updated!

  • @dave1904 ok but I think you might need the steps I provided in previous posts in this thread.

  • @phenomlab A complete reset feels a bit like an overkill for one plugin not working which, as julian I think mentioned, could be re-developed soon. But the plugin keeps active on dev, even after activating many plugins again.

  • @dave1904 said in nodebb-plugin-reactions not working @v1.0.2 with Harmony theme:

    @phenomlab A complete reset feels a bit like an overkill for one plugin not working which, as julian I think mentioned, could be re-developed soon. But the plugin keeps active on dev, even after activating many plugins again.

    Yes, I agree, but I didn’t mean that - sorry.

    What I meant was using

    npm config set legacy-peer-deps true

    On prod and running the /nodebb upgrade to see if that helps.

  • @phenomlab Thanks for reminding me on this one. I just tried that but still no success.

  • @dave1904 what was the output of the upgrade? Did it complain about any missing dependencies?

  • @phenomlab

    I couldn’t see that:

    Updating NodeBB...
    
    1. Updating package.json file with defaults...  OK
    
    2. Bringing base dependencies up to date...  started
    
    up to date, audited 1113 packages in 7s
    
    131 packages are looking for funding
      run `npm fund` for details
    
    13 vulnerabilities (7 moderate, 6 high)
    
    To address issues that do not require attention, run:
      npm audit fix
    
    To address all issues possible (including breaking changes), run:
      npm audit fix --force
    
    Some issues need review, and may require choosing
    a different dependency.
    
    Run `npm audit` for details.
    
    3. Checking installed plugins for updates...Checking installed plugins and themes for updates...   OK
    
    A total of 1 package(s) can be upgraded:
    
      * nodebb-plugin-question-and-answer (1.0.17 -> 1.0.18)
    
    Proceed with upgrade (y|n)? y
    
    Upgrading packages...
    
    4. Updating NodeBB data store schema...
    Parsing upgrade scripts... 
    OK | 0 script(s) found, 125 skipped
    Schema update complete!
    
    
    5. Rebuilding assets...  started
    2023-05-01T21:02:24.095Z [4567/261222] - info: [build] Building in series mode
    2023-05-01T21:02:24.096Z [4567/261222] - info: [build]         plugin static dirs  build started
    2023-05-01T21:02:24.105Z [4567/261222] - info: [build]         plugin static dirs  build completed in 0.009sec
    2023-05-01T21:02:24.106Z [4567/261222] - info: [build]          requirejs modules  build started
    2023-05-01T21:02:24.254Z [4567/261222] - info: [build]          requirejs modules  build completed in 0.148sec
    2023-05-01T21:02:24.254Z [4567/261222] - info: [build]           client js bundle  build started
    2023-05-01T21:02:24.259Z [4567/261222] - info: [build]           client js bundle  build completed in 0.005sec
    2023-05-01T21:02:24.260Z [4567/261222] - info: [build]            admin js bundle  build started
    2023-05-01T21:02:24.261Z [4567/261222] - info: [build]            admin js bundle  build completed in 0.001sec
    2023-05-01T21:02:24.261Z [4567/261222] - info: [build]         client side styles  build started
    Deprecation Warning on line 68, column 52 of node_modules/bootswatch/dist/flatly/_variables.scss: 
    !default should only be written once for each variable.
    This will be an error in Dart Sass 2.0.0.
       ╷
    68 │ $nav-link-padding-y:                .5rem !default !default;
       │                                                    ^^^^^^^^
       ╵
    
    Deprecation Warning on line 70, column 56 of node_modules/bootswatch/dist/flatly/_variables.scss: 
    !default should only be written once for each variable.
    This will be an error in Dart Sass 2.0.0.
       ╷
    70 │ $nav-link-disabled-color:           $gray-600 !default !default;
       │                                                        ^^^^^^^^
       ╵
    
    2023-05-01T21:02:30.523Z [4567/261222] - info: [build]         client side styles  build completed in 6.262sec
    2023-05-01T21:02:30.524Z [4567/261222] - info: [build] admin control panel styles  build started
    2023-05-01T21:02:35.223Z [4567/261222] - info: [build] admin control panel styles  build completed in 4.698sec
    2023-05-01T21:02:35.226Z [4567/261222] - info: [build]                  templates  build started
    2023-05-01T21:02:36.223Z [4567/261222] - info: [build]                  templates  build completed in 0.997sec
    2023-05-01T21:02:36.223Z [4567/261222] - info: [build]                  languages  build started
    2023-05-01T21:02:39.308Z [4567/261222] - info: [build]                  languages  build completed in 3.085sec
    2023-05-01T21:02:39.309Z [4567/261222] - info: [build] Bundling with Webpack.
    2023-05-01T21:03:07.379Z [4567/261222] - info: [build] Bundling took 23607 ms
    2023-05-01T21:03:07.394Z [4567/261222] - info: [build] Asset compilation successful. Completed in 43.284sec.
    
    
                                                NodeBB Upgrade Complete!
    
  • @dave1904 yes, that looks clean. On prod, could you provide the output of

    ./nodebb plugins

    I’m specifically interested in the version numbers of the emoji and reactions plugins. However, as dev is a replica of prod, I suspect the same “fix” (as heavy handed as it is) is needed for prod.

    However, I do agree that this approach isn’t desirable for obvious reasons.

  • Yes, I also have that bad feeling only reset would help. Anyway here is the output:

    Active plugins:
            * @nodebb/nodebb-plugin-reactions@1.0.2 (installed, enabled)
            * nodebb-plugin-2factor@7.0.5 (installed, disabled)
            * nodebb-plugin-beep@0.4.7 (installed, disabled)
            * nodebb-plugin-composer-default@10.0.48 (installed, enabled)
            * nodebb-plugin-contact-page@1.3.0 (installed, disabled)
            * nodebb-plugin-custom-pages@2.0.3 (installed, enabled)
            * nodebb-plugin-customize@3.0.0 (installed, disabled)
            * nodebb-plugin-dbsearch@6.0.0 (installed, enabled)
            * nodebb-plugin-email-blacklist@2.0.0 (installed, disabled)
            * nodebb-plugin-emoji@5.0.6 (installed, enabled)
            * nodebb-plugin-emoji-android@4.0.0 (installed, disabled)
            * nodebb-plugin-emoji-one@4.0.0 (installed, enabled)
            * nodebb-plugin-emoji-vital@4.0.0 (installed, disabled)
            * nodebb-plugin-markdown@12.0.2 (installed, enabled)
            * nodebb-plugin-mentions@4.1.0 (installed, enabled)
            * nodebb-plugin-newsletter@0.10.2 (installed, disabled)
            * nodebb-plugin-night-mode@1.0.7 (installed, disabled)
            * nodebb-plugin-ns-likes@3.0.0 (installed, disabled)
            * nodebb-plugin-ntfy@1.0.15 (installed, disabled)
            * nodebb-plugin-poll@3.0.4 (installed, enabled)
            * nodebb-plugin-question-and-answer@1.0.18 (installed, enabled)
            * nodebb-plugin-recent-cards@3.1.11 (installed, enabled)
            * nodebb-plugin-shoutbox@2.0.4 (installed, disabled)
            * nodebb-plugin-spam-be-gone@2.0.6 (installed, enabled)
            * nodebb-plugin-tenor-gif@3.0.0 (installed, enabled)
            * nodebb-plugin-youtube-embed@0.6.9 (installed, enabled)
            * nodebb-rewards-essentials@0.2.3 (installed, enabled)
            * nodebb-theme-harmony@1.0.1 (installed, enabled)
            * nodebb-theme-lavender@7.0.9 (installed, disabled)
            * nodebb-theme-peace@2.0.19 (installed, disabled)
            * nodebb-theme-persona@13.0.56 (installed, disabled)
            * nodebb-theme-slick@2.0.2 (installed, disabled)
            * nodebb-theme-vanilla@12.1.19 (installed, disabled)
            * nodebb-widget-essentials@7.0.9 (installed, enabled)
            * nodebb-widget-ns-stats@3.0.0 (installed, disabled)
    
  • Instead of a complete reset, would you be open to disabling all plugins apart from the stock ones, plus emoji, emoji android, and reactions?

    Obviously you’ll need to perform a rebuild and restart.

  • Do you know if I would have to reconfigure all the disabled plugins?

  • @dave1904 no, that won’t be necessary. Disabling them means that they won’t be loaded, but will keep their settings.

  • @phenomlab Yes I just thought I could have checked that myself on dev 😄 Yes I would try that but is there a list of the stock plugins?

  • @dave1904 umm. That’s a good question. I’m not sure there is. Let’s start with the below

    @nodebb/nodebb-plugin-reactions
    nodebb-plugin-composer-default
    nodebb-plugin-emoji
    nodebb-plugin-emoji-android
    nodebb-plugin-markdown
    nodebb-plugin-mentions
    nodebb-theme-harmony
    

    If reactions starts playing ball, then we enable the other extensions.


Did this solution help you?
Did you find the suggested solution useful? Why not buy me a coffee? It's a nice gesture, and a great way to show your appreciation 💗

  • 4 Votes
    4 Posts
    133 Views

    @Norrad Are you looking for anything in particular? I only ask because Sudonix uses a number of custom functions which I wrote, but all are available on GitHub and fully supported here.

  • Nodebb design

    Solved General
    2
    1 Votes
    2 Posts
    147 Views

    @Panda said in Nodebb design:

    One negative is not being so good for SEO as more Server side rendered forums, if web crawlers dont run the JS to read the forum.

    From recollection, Google and Bing have the capability to read and process JS, although it’s not in the same manner as a physical person will consume content on a page. It will be seen as plain text, but will be indexed. However, it’s important to note that Yandex and Baidu will not render JS, although seeing as Google has a 90% share of the content available on the web in terms of indexing, this isn’t something you’ll likely lose sleep over.

    @Panda said in Nodebb design:

    The “write api” is preferred for server-to-server interactions.

    This is mostly based around overall security - you won’t typically want a client machine changing database elements or altering data. This is why you have “client-side” which could be DOM manipulation etc, and “server-side” which performs more complex operations as it can communicate directly with the database whereas the client cannot (and if it can, then you have a serious security flaw). Reading from the API is perfectly acceptable on the client-side, but not being able to write.

    A paradigm here would be something like SNMP. This protocol exists as a UDP (UDP is very efficient, as it is “fire and forget” and does not wait for a response like TCP does) based service which reads performance data from a remote source, thus enabling an application to parse that data for use in a monitoring application. In all cases, SNMP access should be “RO” (Read Only) and not RW (Read Write). It is completely feasible to assume complete control over a firewall for example by having RW access to SNMP and then exposing it to the entire internet with a weak passphrase.

    You wouldn’t do it (at least, I hope you wouldn’t) and the same ethic applies to server-side rendering and the execution of commands.

  • 3 Votes
    11 Posts
    280 Views

    For anyone else following this thread

    https://community.nodebb.org/topic/17402/change-in-reply-to-xxxx-text

    And

    https://github.com/NodeBB/NodeBB/commit/f2152953cddd3247746ef393516b0a53ba7750a4

  • 1 Votes
    4 Posts
    167 Views

    @Vijay-Kumavat-0 I think you’d be better off customising the plugin above to be honest. It seems like you’d be reinventing the wheel otherwise.

    I’d modify

    /nodebb/node_modules/nodebb-rewards-essentials/lib/conditions.js
    /nodebb/node_modules/nodebb-rewards-essentials/lib/rewards.js

    These seem to be the two files that control what is in the dropdown lists.

  • Issues with 2nd NodeBB installation

    Solved General
    22
    3 Votes
    22 Posts
    1k Views

    @cagatay yes, that will be fine. Just watch for potential caching conflicts as you will have two sites writing to the one instance of iframely.

  • 0 Votes
    5 Posts
    393 Views

    @qwinter this particular site uses the code I wrote if you want to see it in action. It’s a information and intelligence gatherer I designed for collecting various information security articles from around the globe and consolidating them in one place.

    Essentially, each “post” is in fact generated by the script, and the NodeBB API.

    https://hostrisk.com/

  • NodeBB vs Flarum for a non developer

    Solved General
    17
    10 Votes
    17 Posts
    940 Views

    @marusaky That’s really easily done. I think the docs need updating for the latest release. Did you land up on the 18.x train ?

  • Nodebb Hashtag plugin

    Solved General
    15
    1 Votes
    15 Posts
    727 Views

    @jac Great ! I’ll close this off.